Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #354
Description of changes:
This PR changes the Package.swift Include/Exclude strategy due to the fact that OS checks in the package.swift are evaluated against the host platform instead of the target platform, which caused any checks for
#if os(Android)to fail.The idea is to move header includes to a later stage where the target platform is evaluated.
This also includes AWS-LC seeing its the LibCrypto used by aws-crt-java.
I'm sure there are better ways to achieve this and I am eager to address any feedback.
After spending more time on this codebase since my last attempt, I trust this is a feasible initiative given that the dependencies used by this package are also used by aws-crt-java.